Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: usb: udc_stm32: Handle HAL callbacks on separate thread #80820

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+222 −150
Open

drivers: usb: udc_stm32: Handle HAL callbacks on separate thread #80820

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ce5ab8
drivers: udc: stm32: run clang-format on udc_stm32.c
topisani Nov 3, 2024
8660264
drivers: udc: stm32: add kconfig dependency on !USB_DC_STM32
topisani Dec 1, 2024
89c3a74
drivers: udc: stm32: Offload data callbacks to thread
topisani Nov 3, 2024
a383276
drivers: udc: stm32: set the hs capability if high speed is available
topisani Nov 20, 2024
8e6c8ae
drivers: udc: stm32: Fix RX FIFO min size
topisani Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions drivers/usb/udc/Kconfig.stm32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ config UDC_STM32
depends on DT_HAS_ST_STM32_OTGFS_ENABLED \
|| DT_HAS_ST_STM32_OTGHS_ENABLED \
|| DT_HAS_ST_STM32_USB_ENABLED
depends on !USB_DC_STM32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfischer-no I guess this issue is wider than STM32 and related to #81308. Are you fine this line ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also a bit specific to this driver though - at least theoretically it should be possible with multi-instance compatible controllers to use one with the new api, and one with the old. But the two stm32 drivers specifically cannot coexist because of the Hal callback definitions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, Thanks. Fine for me then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USB_DC_STM32 cannot be used here, once deprecated it should fail in CI.

select USE_STM32_LL_USB
select USE_STM32_HAL_PCD
select USE_STM32_HAL_PCD_EX
Expand Down