-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver: adc: Use logging API #81124
Merged
Merged
driver: adc: Use logging API #81124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
previously approved these changes
Nov 25, 2024
ping @anangl |
anangl
previously approved these changes
Dec 12, 2024
gmarull
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, improve commit title. this is just touching a single driver.
dfe10b1
to
a32c008
Compare
gmarull
reviewed
Dec 12, 2024
a32c008
to
1531f5b
Compare
Use logging API instead of printk Remove ampersand for function Signed-off-by: Steven Chang <[email protected]>
1531f5b
to
e0d11f4
Compare
gmarull
approved these changes
Dec 16, 2024
anangl
approved these changes
Dec 16, 2024
kartben
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use logging API instead of printk
Remove ampersand for function