MKS CANable V2.0 #81366

KozhinovAlexander · 2024-11-13T23:41:40Z

add new board MKS CANable V2.0 Please refer to added documentation for more information.
The hardware of the board can be dound under: https://github.com/makerbase-mks/CANable-MKS

KozhinovAlexander · 2024-11-13T23:43:02Z

@henrikbrixandersen You will see an overlay for this board in CANnectivity later. ;) Thus please take a look too.

nordicjm

Board is OK, please fix ordering issue

KozhinovAlexander · 2024-11-14T07:25:34Z

Board is OK, please fix ordering issue

Thank you for you review. Great to see a feedback from hwv2 guy :) I'll do necessary changes today late night.

boards/makerbase/mks_canable_v20/doc/index.rst

boards/makerbase/mks_canable_v20/mks_canable_v20.dts

nordicjm

Updates need squashing i.e. 2 commits

KozhinovAlexander · 2024-11-15T08:03:44Z

Updates need squashing i.e. 2 commits

Thank you. It is done now.

nordicjm · 2024-11-15T08:26:01Z

Updates need squashing i.e. 2 commits

Thank you. It is done now.

So the second vendor update commit needs squashing into the first vendor update commit and the second board commit needs squashing into the first board commit. Something like this:

git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change first to edit, third to fixup, forth to drop
git cherry-pick ddf9bfdf02006c2dc4e2012ae5ad93a3a0fde584
git rebase --continue
git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change second to fixup

Now you should have 2 commits

KozhinovAlexander · 2024-11-15T08:31:04Z

Updates need squashing i.e. 2 commits

Thank you. It is done now.

So the second vendor update commit needs squashing into the first vendor update commit and the second board commit needs squashing into the first board commit. Something like this:
git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change first to edit, third to fixup, forth to drop
git cherry-pick ddf9bfdf02006c2dc4e2012ae5ad93a3a0fde584
git rebase --continue
git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change second to fixup
Now you should have 2 commits

Got it. Will do.

henrikbrixandersen

Given that upstream threats this as one of multiple board variants (see https://github.com/makerbase-mks/CANable-MKS), I think we might want to do the same (bu renaming the board folder etc.). Support for the V1.0 and the PRO editions can then be added later on. What do you think?

boards/makerbase/index.rst

boards/makerbase/mks_canable_v20/board.yml

boards/makerbase/mks_canable_v20/doc/index.rst

henrikbrixandersen · 2024-11-18T10:38:25Z

boards/makerbase/mks_canable_v20/doc/index.rst

+********
+
+The Makerbase MKS CANable V2.0 board features an ARM Cortex-M4 based STM32G431C8 MCU
+with a wide range of connectivity support and configurations.


A range of? Not on this board, so I think that can be removed from the board description.

MCU supports a range of.... But in terms of board I agree and will update

henrikbrixandersen · 2024-11-18T10:39:32Z

boards/makerbase/mks_canable_v20/doc/index.rst

+The stm32g431c8 mcu is the core of MKS CANable V2.0 board and it has 6 GPIO controllers.
+These controllers are responsible for pin muxing, input/output, pull-up, etc.


This is not that important for the board configuration and could be removed.

henrikbrixandersen · 2024-11-18T10:47:02Z

boards/makerbase/mks_canable_v20/mks_canable_v20.yaml

+  - rng
+  - counter


Have you ran the tests for these?

henrikbrixandersen · 2024-11-18T10:47:10Z

boards/makerbase/mks_canable_v20/mks_canable_v20.yaml

+  - pinctrl
+  - usb_device
+  - usbd
+  - watchdog


henrikbrixandersen · 2024-11-18T10:47:26Z

boards/makerbase/mks_canable_v20/mks_canable_v20_defconfig

+CONFIG_GPIO=y
+CONFIG_ARM_MPU=y
+CONFIG_HW_STACK_PROTECTION=y
+CONFIG_ENTROPY_GENERATOR=y


Why is CONFIG_ENTROPY_GENERATOR enabled?

henrikbrixandersen · 2024-11-18T10:48:34Z

boards/makerbase/mks_canable_v20/support/openocd.cfg

+if {[version_compare $current_version "0.12.0"] >= 0} {
+	# OpenOCD version is 0.12.0 or newer
+	init
+	rtt setup 0x20000000 10000 "SEGGER RTT"
+	rtt start
+	rtt server start 9090 0
+} else {
+	# OpenOCD version is older than 0.12.0
+	echo "Warn: Segger RTT is not supported for this OpenOCD version: $current_version"
+}


This looks very generic and should probably not just be set for one board. It could go into a common OpenOCD configuration file.

Do you mean by common the configuration file delivered with OpenOCD itself?

I meant boards/common/openocd.board.cmake. I would suggest submitting this in a separate PR.

dts/bindings/vendor-prefixes.txt

henrikbrixandersen · 2024-11-18T20:06:09Z

boards/makerbase/mks_canable_v20/doc/index.rst

+-----------+------------+-------------------------------------+
+| GPIO      | on-chip    | gpio                                |
+-----------+------------+-------------------------------------+
+| PWM       | on-chip    | pwm                                 |


Where is PWM used on this board?

Planned to use it for PWM LED since i see LEDs on th board as way to bright. But for the current PR it may be removed - agree.

Add Makerbase Co., Ltd. board vendor Signed-off-by: Alexander Kozhinov <[email protected]>

A cheap and affordable stm32g4 based simple CAN and CAN-FD to usb adapter board Reviewed-by: Erwan Gouriou <[email protected]> Signed-off-by: Alexander Kozhinov <[email protected]>

kartben · 2024-11-15T07:46:38Z

boards/makerbase/index.rst

+.. _boards-makerbase:
+
+Makerbase
+##################


Suggested change

##################

#########

kartben · 2024-11-15T07:48:03Z

boards/makerbase/mks_canable_v20/mks_canable_v20.yaml

+toolchain:
+  - zephyr
+  - gnuarmemb
+  - xtools


Suggested change

- xtools

#80466

boards/makerbase/index.rst

KozhinovAlexander requested a review from henrikbrixandersen November 13, 2024 23:42

KozhinovAlexander force-pushed the mks_canable_v2 branch 2 times, most recently from ce12700 to b6f5079 Compare November 13, 2024 23:59

zephyrbot added the area: Devicetree label Nov 13, 2024

zephyrbot requested review from decsny and galak November 13, 2024 23:59

KozhinovAlexander requested review from erwango, decsny and galak and removed request for galak and decsny November 13, 2024 23:59

KozhinovAlexander changed the title ~~Add new board MKS CANable V2.0~~ MKS CANable V2.0 Nov 14, 2024

nordicjm reviewed Nov 14, 2024

View reviewed changes

erwango requested changes Nov 14, 2024

View reviewed changes

KozhinovAlexander force-pushed the mks_canable_v2 branch from 858f91e to bbe0276 Compare November 14, 2024 21:28

KozhinovAlexander requested review from erwango and nordicjm November 15, 2024 07:06

nordicjm reviewed Nov 15, 2024

View reviewed changes

KozhinovAlexander force-pushed the mks_canable_v2 branch from 1bd250e to ddf9bfd Compare November 15, 2024 08:02

KozhinovAlexander requested a review from nordicjm November 15, 2024 08:03

KozhinovAlexander force-pushed the mks_canable_v2 branch from ddf9bfd to f66f16a Compare November 17, 2024 20:03

nordicjm previously approved these changes Nov 18, 2024

View reviewed changes

henrikbrixandersen requested changes Nov 18, 2024

View reviewed changes

KozhinovAlexander dismissed nordicjm’s stale review via cc505eb November 24, 2024 13:05

KozhinovAlexander added 2 commits November 24, 2024 15:13

dts: bindings: vendor-prefixes.txt

4b812ac

Add Makerbase Co., Ltd. board vendor Signed-off-by: Alexander Kozhinov <[email protected]>

boards: makerbase: mks_canable_v20: add new board MKS CANable V2.0

9fae0cb

A cheap and affordable stm32g4 based simple CAN and CAN-FD to usb adapter board Reviewed-by: Erwan Gouriou <[email protected]> Signed-off-by: Alexander Kozhinov <[email protected]>

KozhinovAlexander force-pushed the mks_canable_v2 branch from cc505eb to 9fae0cb Compare November 24, 2024 14:13

kartben reviewed Nov 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MKS CANable V2.0 #81366

MKS CANable V2.0 #81366

KozhinovAlexander commented Nov 13, 2024

KozhinovAlexander commented Nov 13, 2024

nordicjm left a comment

KozhinovAlexander commented Nov 14, 2024

nordicjm left a comment

KozhinovAlexander commented Nov 15, 2024

nordicjm commented Nov 15, 2024

KozhinovAlexander commented Nov 15, 2024

henrikbrixandersen left a comment

henrikbrixandersen Nov 18, 2024 •

edited

Loading

KozhinovAlexander Nov 24, 2024

henrikbrixandersen Nov 18, 2024

henrikbrixandersen Nov 18, 2024

henrikbrixandersen Nov 18, 2024

henrikbrixandersen Nov 18, 2024 •

edited

Loading

henrikbrixandersen Nov 18, 2024

KozhinovAlexander Nov 24, 2024

henrikbrixandersen Nov 24, 2024 •

edited

Loading

henrikbrixandersen Nov 18, 2024

KozhinovAlexander Nov 24, 2024

kartben Nov 15, 2024

kartben Nov 15, 2024

		The stm32g431c8 mcu is the core of MKS CANable V2.0 board and it has 6 GPIO controllers.
		These controllers are responsible for pin muxing, input/output, pull-up, etc.

MKS CANable V2.0 #81366

Are you sure you want to change the base?

MKS CANable V2.0 #81366

Conversation

KozhinovAlexander commented Nov 13, 2024

KozhinovAlexander commented Nov 13, 2024

nordicjm left a comment

Choose a reason for hiding this comment

KozhinovAlexander commented Nov 14, 2024

nordicjm left a comment

Choose a reason for hiding this comment

KozhinovAlexander commented Nov 15, 2024

nordicjm commented Nov 15, 2024

KozhinovAlexander commented Nov 15, 2024

henrikbrixandersen left a comment

Choose a reason for hiding this comment

henrikbrixandersen Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrikbrixandersen Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrikbrixandersen Nov 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrikbrixandersen Nov 18, 2024 •

edited

Loading

henrikbrixandersen Nov 18, 2024 •

edited

Loading

henrikbrixandersen Nov 24, 2024 •

edited

Loading