Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add board "Lilygo TTGO T7 V1.5" #81494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add board "Lilygo TTGO T7 V1.5" #81494

wants to merge 1 commit into from

Conversation

kaessert
Copy link

@kaessert kaessert commented Nov 17, 2024 •
edited
Loading

This PR adds support for the Lilygo TTGO T7 V1.5 baord. It's my first pr of that kind so please be gentle with me :)

@github-actions GitHub Actions
Copy link

Hello @kaessert, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nordicjm
nordicjm requested changes Nov 18, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/lilygo/ttgo_t7v1_5/Kconfig.ttgo_t7v1_5 Outdated Show resolved Hide resolved
boards/lilygo/ttgo_t7v1_5/doc/img/ttgo_t7v1_5.jpg Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolution of this image and the file size needs to come down, a lot. It also needs to be in webp format, then once it is, put it through https://tinypng.com/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shrank the image further, i hope it is small enough now

boards/lilygo/ttgo_t7v1_5/doc/index.rst Outdated Show resolved Hide resolved
boards/lilygo/ttgo_t7v1_5/ttgo_t7v1_5_esp32_procpu_defconfig Outdated Show resolved Hide resolved
@kaessert
Copy link
Author

Thank you so much for your review @nordicjm ! I addressed the comments.

nordicjm
nordicjm reviewed Nov 25, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/Kconfig.defconfig Outdated
Comment on lines 7 to 9
config ESP_WIFI_MAX_THREAD_PRIORITY
int "ESP WiFi Maximum Thread Priority"
default 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what this is but it can go

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

boards/lilygo/ttgo_t7v1_5/Kconfig.defconfig Outdated
Comment on lines 4 to 5
config BOARD_TTGO_T7V1_5
select SOC_ESP32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not go in this file, it should be Kconfig.ttgo_t7v1_5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

boards/lilygo/ttgo_t7v1_5/doc/img/ttgo_t7v1_5.webp Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image is way too big

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced it further, I hope 60kb is okay

sylvioalves
sylvioalves reviewed Nov 25, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/Kconfig Outdated

config HEAP_MEM_POOL_ADD_SIZE_BOARD
int
default 65535 if WIFI && BT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaessert, let this be only default 4096 instead. You can check other esp32-based boards as reference.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sylvioalves
sylvioalves reviewed Nov 25, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/doc/index.rst Outdated
Comment on lines 1 to 4
.. _ttgo_t7v1_5:

Lilygo TTGO T7 V1.5
#################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the 4 lines above to:

.. zephyr:board:: ttgo_t7v1_5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sylvioalves
sylvioalves reviewed Nov 25, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/doc/index.rst Outdated
- JST GH 2-pin battery connector
- LED

.. figure:: img/ttgo_t7v1_5.webp
Copy link
Collaborator

@sylvioalves sylvioalves Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this whole figure entry here (documentation will automatically add it). Please, decrease image size as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sylvioalves
sylvioalves reviewed Nov 25, 2024
View reviewed changes
boards/lilygo/ttgo_t7v1_5/ttgo_t7v1_5_esp32_procpu.dts Outdated
status = "okay";
};

&flash0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you included #include <espressif/esp32/esp32_wrover_e_n4r8.dtsi>, you can remove all this flash0 entry from here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kaessert
Copy link
Author

Thank you so much for your patience 🙏

@nordicjm
Copy link
Collaborator

Can you squash the commits down to one commit?

@kaessert
Copy link
Author

@nordicjm Sure, squashed

@kaessert
boards: "Lilygo TTGO T7 V1.5" initial support
7c84a78 
Add support for board "Lilygo TTGO T7 V1.5"

Signed-off-by: Tobias Kässer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvioalves sylvioalves sylvioalves left review comments

@kartben kartben Awaiting requested review from kartben

@nordicjm nordicjm Awaiting requested review from nordicjm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaessert @nordicjm @sylvioalves