tests: secure_storage: psa: enable malloc arena for Mbed TLS #82099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-font
reviewed
Nov 27, 2024
| @@ -6,6 +6,8 @@ CONFIG_TEST_RANDOM_GENERATOR=y | |||
| CONFIG_TIMER_RANDOM_GENERATOR=y | |||
| CONFIG_MBEDTLS_PSA_CRYPTO_C=y | |||
|
|
|||
| CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=-1 | |||
There was a problem hiding this comment.
Can you put that as part of the CONFIG_MBEDTLS_PSA_CRYPTO_C block? Its requirements (e.g. CONFIG_*_RANDOM_GENERATOR) are above it.
Also, this will cause a (non-fatal) warning on board targets without CONFIG_COMMON_LIBC_MALLOC/CONFIG_MINIMAL_LIBC, which is fine, but can you add a small comment explaining what this is for?
There was a problem hiding this comment.
Do you mean adding the comment to the conf file itself? Sure, I'll do that.
There was a problem hiding this comment.
Yes. Would make it easier for users to get the explanation, as it can show up as a warning in the build.
tomi-font
reviewed
Nov 27, 2024
tagunil
force-pushed
the
psa-enable-arena
branch
from
9d300f9 to
b4cff35
Compare
tomi-font
previously approved these changes
Nov 27, 2024
tagunil
force-pushed
the
psa-enable-arena
branch
from
b4cff35 to
1e3dc59
Compare
The PSA Crypto implementation provided by Mbed TLS generally requires some amount of heap to function, so enable the arena unconditionally to make the test compatible with MINIMAL_LIBC configurations where the arena is disabled by default. Signed-off-by: Ilya Tagunov <[email protected]>
tagunil
force-pushed
the
psa-enable-arena
branch
from
1e3dc59 to
3d36a9c
Compare
|
I've limited the size of the arena to fix qemu test failures. |
tomi-font
approved these changes
Nov 28, 2024
valeriosetti
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PSA Crypto implementation provided by Mbed TLS generally requires some amount of heap to function, so enable the arena unconditionally to make the test compatible with MINIMAL_LIBC configurations where the arena is disabled by default.