Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement video control framework #82158

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Implement video control framework #82158

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6fc1d3e
drivers: video: Add endpoint DT helpers
ngphibang Oct 30, 2024
8b3c3c5
drivers: video: mipi_csi2rx: Use endpoint DT helpers
ngphibang Oct 30, 2024
b98753e
drivers: video: csi: Use endpoint DT helpers
ngphibang Oct 30, 2024
4080680
drivers: video: Introduce video device and its surroundings
ngphibang Nov 25, 2024
0fe00c7
drivers: video: Introduce video async mechanism
ngphibang Nov 26, 2024
a7ea463
include: video-controls: Add video_control struct
ngphibang Nov 26, 2024
81be3e1
drivers: video: Implement video control framework
ngphibang Nov 26, 2024
356e98b
drivers: video: ov5640: Fix brightness control
ngphibang Nov 27, 2024
1583d64
drivers: video: csi: Move instance-independant stuffs to common init
ngphibang Nov 27, 2024
62695e3
drivers: video: Use the new video control framework
ngphibang Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions drivers/video/video_mcux_csi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@
#include <fsl_cache.h>
#endif

#if defined(CONFIG_VIDEO_MCUX_MIPI_CSI2RX)
#define DEVICE_DT_INST_GET_SOURCE_DEV(n) \
DEVICE_DT_GET(DT_PARENT(DT_GPARENT(DT_NODELABEL(DT_STRING_TOKEN( \
DT_CHILD(DT_INST_CHILD(n, port), endpoint), remote_endpoint_label)))))
#else
#define DEVICE_DT_INST_GET_SOURCE_DEV(n) \
DEVICE_DT_GET(DT_GPARENT(DT_NODELABEL(DT_STRING_TOKEN( \
DT_CHILD(DT_INST_CHILD(n, port), endpoint), remote_endpoint_label))))
#endif

struct video_mcux_csi_config {
CSI_Type *base;
const struct device *source_dev;
Expand Down Expand Up @@ -502,7 +492,7 @@ PINCTRL_DT_INST_DEFINE(0);

static const struct video_mcux_csi_config video_mcux_csi_config_0 = {
.base = (CSI_Type *)DT_INST_REG_ADDR(0),
.source_dev = DEVICE_DT_INST_GET_SOURCE_DEV(0),
.source_dev = DEVICE_DT_GET_REMOTE_DEVICE(DT_INST_ENDPOINT_BY_ID(0, 0, 0)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make these changes to use the helpers in one commit , you dont need one commit per file when they are all doing the same thing , its a mass change

.pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(0),
};

Expand Down