usb: device: remove USB H4 Bluetooth function and sample #82805
Conversation
zephyrbot
added
area: USB
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
HoZHel,
jhedberg,
kartben,
nashif,
sjanc,
Thalley,
theob-pro and
tmon-nordic
No matter what the documentation says, there is no support for this in btusb. The only purpose why it could be there was/is in fact served with hci_usb.
Do you want me to remove it immediately and not deprecate with the legacy USB stack? |
The Bluetooth HCI USB transport layer implementation is provided by "subsys/usb/device/class/bluetooth.c". The USB H4 Bluetooth function implements a non-standard transport layer. There is no known host-side equivalent that uses this protocol. Note that the H4 protocol functionality is also provided by the "subsys/usb/device/class/bluetooth.c". Since that there are no real USB H4 Bluetooth users, remove the implementation and sample without deprecation. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-remove-usb-h4-sample
branch
from
23b0af8 to
0448609
Compare
jfischer-no
changed the title
jfischer-no
changed the title
|
@jhedberg I was of the belief that Bluez had support for this vendor specific btusb support that did a pass-through of all HCI types (including ISO data) over USB transport... is this is not true, I have no objection to remove this sample. @Thalley you may want to make a comment here #44013 on the actions taken by this PR |
This support isn't upstream in Linux/BlueZ, AFAIK. I did a quick check with @Vudentz and he was fine with this sample getting removed. I also got the impression that there might be some standard coming for this at some point, in which case the sample would either way need to be removed or overhauled. |
https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/bluetooth/hci_usb was used for this, but this cannot be discussed openly. |
...can we add analytics to west so we have data of what samples are used? 👀 (/me ducks) |
What is west? (⊙.☉)7 |
What is west? |
There is very high confidence that this sample has no user or use on the host side (there is no implementation in btusb to handle it). Furthermore, the functionality can also be provided by the sample/bluetooth/hci_usb sample.
cherry-picked from #80985