-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: openthread: Adding diag transmit
command.
#82911
Merged
kartben
merged 1 commit into
zephyrproject-rtos:main
from
canisLupus1313:add_diag_transmit
Dec 16, 2024
Merged
net: openthread: Adding diag transmit
command.
#82911
kartben
merged 1 commit into
zephyrproject-rtos:main
from
canisLupus1313:add_diag_transmit
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
edmont,
maciejbaczmanski,
mariuszpos,
pdgendt and
rlubos
December 12, 2024 08:38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth exiting early in most places where we assign error value (like OT_ERROR_INVALID_ARGS
etc. For example now we allow setting interval to a negative value and will cast it to uint32_t
rlubos
reviewed
Dec 12, 2024
canisLupus1313
force-pushed
the
add_diag_transmit
branch
2 times, most recently
from
December 13, 2024 10:58
46247a9
to
80f14be
Compare
rlubos
reviewed
Dec 16, 2024
canisLupus1313
force-pushed
the
add_diag_transmit
branch
from
December 16, 2024 09:28
ea97b26
to
737cc8b
Compare
rlubos
previously approved these changes
Dec 16, 2024
Commit adds `diag transmit` used for transmission IEEE802154 packets in specific amount and interval. Signed-off-by: Przemyslaw Bida <[email protected]>
canisLupus1313
force-pushed
the
add_diag_transmit
branch
from
December 16, 2024 09:34
737cc8b
to
76df2ad
Compare
maciejbaczmanski
approved these changes
Dec 16, 2024
rlubos
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit adds
diag transmit
used for transmission IEEE802154 packets in specific amount and interval.