Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: openthread: Adding diag transmit command. #82911

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

canisLupus1313
Copy link
Contributor

Commit adds diag transmit used for transmission IEEE802154 packets in specific amount and interval.

Copy link
Member

@maciejbaczmanski maciejbaczmanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth exiting early in most places where we assign error value (like OT_ERROR_INVALID_ARGS etc. For example now we allow setting interval to a negative value and will cast it to uint32_t

modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Show resolved Hide resolved
modules/openthread/platform/diag.c Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
@canisLupus1313 canisLupus1313 force-pushed the add_diag_transmit branch 2 times, most recently from 46247a9 to 80f14be Compare December 13, 2024 10:58
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
modules/openthread/platform/diag.c Outdated Show resolved Hide resolved
rlubos
rlubos previously approved these changes Dec 16, 2024
Commit adds `diag transmit` used for transmission IEEE802154 packets
in specific amount and interval.

Signed-off-by: Przemyslaw Bida <[email protected]>
@kartben kartben merged commit 1512ed2 into zephyrproject-rtos:main Dec 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants