unittest: add COMPILER_WARNINGS_AS_ERRORS handling #82928
Merged
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
unittest-warning
branch
from
5b8cd7c to
0dc50ad
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jthm-ot,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr,
sjanc and
Thalley
kartben
previously approved these changes
Dec 12, 2024
Thalley
reviewed
Dec 12, 2024
tests/bluetooth/audio/cap_commander/src/test_broadcast_reception.c
Outdated
Show resolved
Hide resolved
fabiobaltieri
force-pushed
the
unittest-warning
branch
2 times, most recently
from
3d16071 to
0e3e782
Compare
jhedberg
reviewed
Dec 12, 2024
subsys/bluetooth/host/hci_core.h
Outdated
Comment on lines
11
to
13
| #ifndef ZTEST_UNITTEST | ||
| #include <zephyr/devicetree.h> | ||
| #endif |
There was a problem hiding this comment.
Wouldn't it make more sense to have this #ifndef inside the devicetree.h file itself, so that not everybody who wants to include it needs to know of this exception?
There was a problem hiding this comment.
Yeah not liking that either, but hey seems like that override was only needed on the linker file itself, I added a couple of undef for those at the end of the file and that seems to work, so that crappy hack is self contained at least.
Undefine the DT_NODE_HAS_STATUS and DT_NODE_HAS_STATUS_OKAY no nop at the end of the file so other uses can include devicetree.h without generating a compiler warning. Signed-off-by: Fabio Baltieri <[email protected]>
Fix various unit test build warnings, unused variables, set but unused variables, wrong types etc... Signed-off-by: Fabio Baltieri <[email protected]>
This flag is set on other compiler as well for normal builds, and suppresses a warning for empty print, which is apparently quite common. The unit test build uses its own flags so set it there as well to get the same behavior as with the rest of the code base. Signed-off-by: Fabio Baltieri <[email protected]>
Add a check to set the warnings_as_errors flags in unit tests if CONFIG_COMPILER_WARNINGS_AS_ERRORS is specified, this should catch warnings in unit test twister runs. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
unittest-warning
branch
from
0e3e782 to
3e31c8a
Compare
jhedberg
approved these changes
Dec 13, 2024
Thalley
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to set the warnings_as_errors flags in unit tests if CONFIG_COMPILER_WARNINGS_AS_ERRORS is specified, this should catch warnings in unit test twister runs.