Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: nrf7002dk: Fix SR coexistence GPIOs ownership #83028

Merged
merged 1 commit into from
Dec 18, 2024
Merged

boards: nrf7002dk: Fix SR coexistence GPIOs ownership #83028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions boards/nordic/nrf7002dk/nrf5340_cpuapp_common.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@
mcuboot-led0 = &led0;
watchdog0 = &wdt0;
};

nrf_radio_coex: coex {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use generic gpio forwarder node for this purpose?

zephyr/boards/nordic/nrf7002dk/nrf5340_cpuapp_common.dtsi

Line 94 in 4272353

gpio_fwd: nrf-gpio-forwarder {

You could add there:

	gpio_fwd: nrf-gpio-forwarder {
		compatible = "nordic,nrf-gpio-forwarder";
		status = "okay";
		uart {
			gpios = <&gpio1 1 0>, <&gpio1 0 0>, <&gpio1 5 0>, <&gpio1 4 0>;
		};
		coex {
			gpios = <&gpio0 28 0>, <&gpio0 30 0>, <&gpio0 24 0>, <&gpio0 29>;
		};
	};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... as already mentioned by #83028 (review)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we agreed to use that, but wanted to get some context about removing the manual forwarding from MPSL in NCS.

status = "okay";
compatible = "nordic,nrf7002-coex";
req-gpios = <&gpio0 28 GPIO_ACTIVE_HIGH>;
status0-gpios = <&gpio0 30 GPIO_ACTIVE_HIGH>;
grant-gpios = <&gpio0 24 (GPIO_PULL_DOWN | GPIO_ACTIVE_LOW)>;
swctrl1-gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;
};
};

&vregmain {
Expand Down
Loading