twister: add dt_node_prop_enabled support #83035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
butok,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
gchwier,
golowanow,
KamilxPaszkiet,
kartben,
LukaszMrugala,
mmahadevan108,
nashif,
PerMac and
yvanderv
|
with this fix the build is filter out correctly and mimxrt1170_evk works fine |
decsny
previously approved these changes
Dec 17, 2024
kartben
reviewed
Dec 17, 2024
nashif
reviewed
Dec 17, 2024
| @@ -9,5 +9,5 @@ common: | |||
| - pytest | |||
| tests: | |||
| sample.boards.mimxrt1170_evk.magic_addr: | |||
| filter: CONFIG_MEMC_NXP_FLEXRAM | |||
| filter: CONFIG_MEMC_NXP_FLEXRAM and dt_node_prop_enabled("flexram", "flexram,has-magic-addr") | |||
There was a problem hiding this comment.
do you still need DT_HAS_NXP_FLEXRAM_ENABLED here? this is enabled depending on DTS already.
There was a problem hiding this comment.
yes, we can remove the CONFIG_MEMC_NXP_FLEXRAM updated
using "dt_node_prop_enabled" to filter out supported platforms 1. check node existing. 2. check prop in node. 3. check the prop is True. Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
flexram_memctl_fix
branch
from
41cbb5e to
387115b
Compare
decsny
approved these changes
Dec 18, 2024
mmahadevan108
approved these changes
Dec 20, 2024
decsny
added
the
Hotfix
|
the magic address testcase blocking CI now due to testing on rt10xx |
dleach02
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using "dt_node_prop_enabled" to filter out supported platforms
fixes: #83036