Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: drivers: clock_control stm32 bus clock index can exceed 256 #83038

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Dec 16, 2024

For some stm32 devices, especially the stm32H7RS serie, the RCC register map is larger that 256 (example AHB1 is 0x138). The mask is extended to 512 in the .bus of the clock info structure.

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Clock Control labels Dec 16, 2024
@FRASTM FRASTM added the platform: STM32 ST Micro STM32 label Dec 16, 2024
@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 17, 2024

replacing the mask 0x1FF with GENMASK(STM32_CLOCK_DIV_SHIFT - 1, 0)

erwango
erwango previously approved these changes Dec 17, 2024
@erwango erwango assigned erwango and unassigned nordic-krch Dec 17, 2024
mathieuchopstm
mathieuchopstm previously approved these changes Dec 17, 2024
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An intermediary #define xxx GENMASK(STM32_CLOCK_DIV_SHIFT - 1, 0) could be introduced to make macro less ugly, but non-blocker.

mniestroj
mniestroj previously approved these changes Dec 17, 2024
For some stm32 devices, especially the stm32H7RS serie,
the RCC register map is larger that 256 (example  AHB1 is 0x138).
The mask is extended to 0x1ff in the .bus of the clock info structure,
using the GENMASK macro from STM32_CLOCK_DIV_SHIFT

Signed-off-by: Francois Ramu <[email protected]>
@kartben kartben requested a review from erwango December 18, 2024 02:16
@kartben kartben merged commit 7cbb1dd into zephyrproject-rtos:main Dec 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Clock Control platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants