-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include: drivers: clock_control stm32 bus clock index can exceed 256 #83038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
254e041
to
95b1735
Compare
replacing the mask |
erwango
previously approved these changes
Dec 17, 2024
mathieuchopstm
previously approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An intermediary #define xxx GENMASK(STM32_CLOCK_DIV_SHIFT - 1, 0)
could be introduced to make macro less ugly, but non-blocker.
mniestroj
previously approved these changes
Dec 17, 2024
For some stm32 devices, especially the stm32H7RS serie, the RCC register map is larger that 256 (example AHB1 is 0x138). The mask is extended to 0x1ff in the .bus of the clock info structure, using the GENMASK macro from STM32_CLOCK_DIV_SHIFT Signed-off-by: Francois Ramu <[email protected]>
ec9a5c4
95b1735
to
ec9a5c4
Compare
mniestroj
approved these changes
Dec 17, 2024
mathieuchopstm
approved these changes
Dec 17, 2024
erwango
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Clock Control
platform: STM32
ST Micro STM32
size: XS
A PR changing only a single line of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some stm32 devices, especially the stm32H7RS serie, the RCC register map is larger that 256 (example AHB1 is 0x138). The mask is extended to 512 in the .bus of the clock info structure.