Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: mbox: nrf_vevif_event: add workaround for nRF54L errata 16 #83057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −7
Open

drivers: mbox: nrf_vevif_event: add workaround for nRF54L errata 16 #83057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/mbox/Kconfig.nrf_vevif_event
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@ config MBOX_NRF_VEVIF_EVENT_TX
default y
help
Mailbox driver for transmitting events from VPR to a remote core

config MBOX_NRF_VEVIF_EVENT_USE_54L_ERRATA_16
bool "Apply errata 16 for nRF54L series"
default y if SOC_SERIES_NRF54LX
30 changes: 23 additions & 7 deletions drivers/mbox/mbox_nrf_vevif_event_rx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
#define EVENTS_IDX_MIN NRF_VPR_EVENTS_TRIGGERED_MIN
#define EVENTS_IDX_MAX NRF_VPR_EVENTS_TRIGGERED_MAX

#if defined(CONFIG_MBOX_NRF_VEVIF_EVENT_USE_54L_ERRATA_16)
#define VEVIF_54L_EVENT_IDX 20
BUILD_ASSERT(DT_INST_PROP(0, nordic_events) == 1);
BUILD_ASSERT(DT_INST_PROP(0, nordic_events_mask) & BIT(VEVIF_54L_EVENT_IDX));
#endif

/* callbacks */
struct mbox_vevif_event_rx_cbs {
mbox_callback_t cb[EVENTS_IDX_MAX - EVENTS_IDX_MIN + 1U];
Expand All @@ -27,24 +33,34 @@ struct mbox_vevif_event_rx_conf {
void (*irq_connect)(void);
};

static void trigger_callback(const struct device *dev, struct mbox_vevif_event_rx_cbs *cbs,
uint8_t id)
{
uint8_t idx = id - EVENTS_IDX_MIN;

if ((cbs->enabled_mask & BIT(id)) && (cbs->cb[idx] != NULL)) {
cbs->cb[idx](dev, id, cbs->user_data[idx], NULL);
}
}

static void vevif_event_rx_isr(const void *device)
{
const struct device *dev = (struct device *)device;
const struct mbox_vevif_event_rx_conf *config = dev->config;
struct mbox_vevif_event_rx_cbs *cbs = dev->data;

#if !defined(CONFIG_MBOX_NRF_VEVIF_EVENT_USE_54L_ERRATA_16)
const struct mbox_vevif_event_rx_conf *config = dev->config;

for (uint8_t id = EVENTS_IDX_MIN; id < EVENTS_IDX_MAX + 1U; id++) {
nrf_vpr_event_t event = nrfy_vpr_triggered_event_get(id);

if (nrfy_vpr_event_check(config->vpr, event)) {
nrfy_vpr_event_clear(config->vpr, event);
uint8_t idx = id - EVENTS_IDX_MIN;

if ((cbs->enabled_mask & BIT(id)) && (cbs->cb[idx] != NULL)) {
cbs->cb[idx](dev, id, cbs->user_data[idx], NULL);
}
trigger_callback(dev, cbs, id);
}
}
#else
trigger_callback(dev, cbs, VEVIF_54L_EVENT_IDX);
#endif
}

static inline bool vevif_event_rx_event_is_valid(uint32_t events_mask, uint32_t id)
Expand Down
7 changes: 7 additions & 0 deletions drivers/mbox/mbox_nrf_vevif_event_tx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ static int vevif_event_tx_send(const struct device *dev, uint32_t id, const stru

nrf_vpr_csr_vevif_events_trigger(BIT(id));

#if defined(CONFIG_MBOX_NRF_VEVIF_EVENT_USE_54L_ERRATA_16)
while (!nrf_vpr_csr_vevif_events_get()) {
;
}
nrf_vpr_csr_vevif_events_set(0);
#endif

return 0;
}

Expand Down
Loading