posix: options: add XSI_REALTIME option group #83303

cfriedt · 2024-12-21T15:23:44Z

Add a POSIX Option Group called XSI_REALTIME (with Kconfig option CONFIG_XSI_REALTIME).

When XSI_REALTIME is selected (or when required POSIX Options are enabled), define _XOPEN_REALTIME to be something other than -1 (_XOPEN_VERSION seemed appropriate).

Doc Preview

Closes #82004
Relates to #79816

Required changes:

lib/posix/options/mlock.c

lib/posix/options/mlockall.c

ycsin

LGTM!

lib/posix/options/Kconfig.mem

cfriedt · 2024-12-24T22:27:54Z

Reviewers might want to take a look workarounds for some weird corner cases

demand paging / default ram backend instead of no implementation (@npitre)
xtensa linker script syntax error (@ceolin)
32-bit x86 and userspace issue (@dcpleung)

The latter two should be reproducible by undoing the workaround commits.

cfriedt · 2025-01-07T10:21:41Z

I'll see if I can separate this PR into smaller, more manageable ones.

Currently, it's blocking #81859, #79454, and others and should have reviews by @dcpleung @ceolin and @npitre on the topics mentioned above.

cfriedt · 2025-01-07T12:58:27Z

rebase on main

cfriedt · 2025-01-28T03:26:03Z

lib/posix/options/Kconfig.xsi_streams

+#
+# SPDX-License-Identifier: Apache-2.0
+
+config XOPEN_STREAMS


This will need to be deprecated and renamed XSI_STREAMS. That's a change for another PR though.

cfriedt · 2025-01-28T03:27:01Z

lib/posix/options/Kconfig.xsi_single_process

+	depends on POSIX_SINGLE_PROCESS
+	depends on POSIX_TIMERS


I think that XSI_SINGLE_PROCESS should select these other options, similarly to how it's done for XSI_REALTIME. That's a change for another PR though.

For the REALTIME_MINIMAL Application Environment Profile, uncomment the POSIX_MEMLOCK, POSIX_MEMLOCK_RANGE, POSIX_MEMORY_PROTECTION, POSIX_MAPPED_FILES, and POSIX_SHARED_MEMORY_OBJECTS options. These should have been uncommented back when Kconfig options for those features were added, so this can probably be called a Kconfig bug. Signed-off-by: Chris Friedt <[email protected]>

Since XSI is composed of several distinct POSIX Option Groups split Kconfig.xsi into separate files - one for each Option Group. Signed-off-by: Chris Friedt <[email protected]>

cfriedt · 2025-01-28T23:49:57Z

@ycsin - should be green shortly (finally 😅)

nordicjm · 2025-01-29T12:18:37Z

lib/posix/options/CMakeLists.txt

 if (NOT CONFIG_TC_PROVIDES_POSIX_MEMORY_PROTECTION)
 zephyr_library_sources_ifdef(CONFIG_POSIX_MEMORY_PROTECTION mprotect.c)


Suggested change

if (NOT CONFIG_TC_PROVIDES_POSIX_MEMORY_PROTECTION)

zephyr_library_sources_ifdef(CONFIG_POSIX_MEMORY_PROTECTION mprotect.c)

if(NOT CONFIG_TC_PROVIDES_POSIX_MEMORY_PROTECTION)

zephyr_library_sources_ifdef(CONFIG_POSIX_MEMORY_PROTECTION mprotect.c)

(for a future PR)

Good catch - we should probably have a cmake linter in GH actions

@nordicjm - created #84876

nordicjm · 2025-01-29T12:18:51Z

lib/posix/options/CMakeLists.txt

@@ -154,6 +142,15 @@ if (NOT CONFIG_TC_PROVIDES_POSIX_THREADS)
  )
 endif()

+if (NOT CONFIG_TC_PROVIDES_XSI_REALTIME)


Suggested change

if (NOT CONFIG_TC_PROVIDES_XSI_REALTIME)

if(NOT CONFIG_TC_PROVIDES_XSI_REALTIME)

Add a POSIX Option Group called XSI_REALTIME (with Kconfig option CONFIG_XSI_REALTIME). When XSI_REALTIME is selected (or when required POSIX Options are enabled), define _XOPEN_REALTIME to be something other than -1 (_XOPEN_VERSION seemed appropriate). Signed-off-by: Chris Friedt <[email protected]>

Mark the XSI_REALTIME Option Group as supported, such that the _XOPEN_REALTIME feature test macro may be tested. Signed-off-by: Chris Friedt <[email protected]>

ycsin

LGTM

cfriedt · 2025-02-02T01:10:28Z

@nordicjm - would you consider giving a second approval?

cfriedt requested a review from ycsin December 21, 2024 15:23

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch 2 times, most recently from da74584 to 3a0cd37 Compare December 21, 2024 15:36

cfriedt mentioned this pull request Dec 21, 2024

tests: posix: common: split XSI_REALTIME to standalone test #81859

Merged

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch 5 times, most recently from 57c39c1 to 4271c7a Compare December 22, 2024 16:24

ycsin reviewed Dec 23, 2024

View reviewed changes

lib/posix/options/mlock.c Outdated Show resolved Hide resolved

lib/posix/options/mlockall.c Outdated Show resolved Hide resolved

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch 2 times, most recently from c66b962 to 561d6c0 Compare December 23, 2024 02:23

cfriedt marked this pull request as ready for review December 23, 2024 10:52

zephyrbot added the area: POSIX POSIX API Library label Dec 23, 2024

zephyrbot requested review from ceolin, dcpleung, nashif and peter-mitsis December 23, 2024 10:53

zephyrbot assigned dcpleung Dec 23, 2024

cfriedt requested a review from ycsin December 23, 2024 12:13

ycsin previously approved these changes Dec 24, 2024

View reviewed changes

lib/posix/options/Kconfig.mem Outdated Show resolved Hide resolved

cfriedt mentioned this pull request Jan 1, 2025

posix: implement FILE_LOCKING, SYSTEM_DATABASE, SYSTEM_DATABASE_R #83368

Draft

10 tasks

cfriedt dismissed ycsin’s stale review via ec1234e January 7, 2025 12:58

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch from 561d6c0 to ec1234e Compare January 7, 2025 12:58

This was referenced Jan 7, 2025

posix: options: mlock: include demand paging header #83645

Merged

posix: options: mlockall: include toolchain header #83647

Merged

posix: options: mlock: refine imply for MMU and DEMAND_PAGING #83648

Merged

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch from 318ec45 to 28baf38 Compare January 22, 2025 12:30

cfriedt mentioned this pull request Jan 22, 2025

arch: x86: fatal: initialize was_valid_access #84354

Merged

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch 4 times, most recently from 287ed0e to 565214f Compare January 28, 2025 03:15

cfriedt commented Jan 28, 2025

View reviewed changes

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch 3 times, most recently from 9b8b32a to 1966a6d Compare January 28, 2025 13:41

cfriedt added area: Documentation and removed area: X86 x86 Architecture (32-bit) labels Jan 28, 2025

cfriedt assigned cfriedt and unassigned dcpleung Jan 28, 2025

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch from 1966a6d to be5622f Compare January 28, 2025 14:24

cfriedt added 2 commits January 28, 2025 18:48

posix: options: split kconfig.xsi into separate option groups

26b270d

Since XSI is composed of several distinct POSIX Option Groups split Kconfig.xsi into separate files - one for each Option Group. Signed-off-by: Chris Friedt <[email protected]>

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch from be5622f to 4928880 Compare January 28, 2025 23:48

nordicjm reviewed Jan 29, 2025

View reviewed changes

cfriedt added 2 commits January 29, 2025 10:17

doc: posix: mark XSI_REALTIME as supported

16443cb

Mark the XSI_REALTIME Option Group as supported, such that the _XOPEN_REALTIME feature test macro may be tested. Signed-off-by: Chris Friedt <[email protected]>

cfriedt force-pushed the issues/82004/posix-create-xsi-realtime-option-group branch from 4928880 to 16443cb Compare January 29, 2025 15:18

cfriedt requested a review from nordicjm January 29, 2025 15:39

ycsin approved these changes Jan 29, 2025

View reviewed changes

nordicjm approved these changes Feb 3, 2025

View reviewed changes

kartben merged commit 1237c86 into zephyrproject-rtos:main Feb 3, 2025
26 checks passed

cfriedt mentioned this pull request Feb 20, 2025

tests: posix: common: separate into smaller testsuites #79454

Open

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

posix: options: add XSI_REALTIME option group #83303

posix: options: add XSI_REALTIME option group #83303

cfriedt commented Dec 21, 2024 •

edited

Loading

ycsin left a comment

cfriedt commented Dec 24, 2024

cfriedt commented Jan 7, 2025 •

edited

Loading

cfriedt commented Jan 7, 2025

cfriedt Jan 28, 2025 •

edited

Loading

cfriedt Jan 28, 2025

cfriedt commented Jan 28, 2025

nordicjm Jan 29, 2025

cfriedt Jan 29, 2025

cfriedt Jan 29, 2025

nordicjm Jan 29, 2025

cfriedt Jan 29, 2025

ycsin left a comment

cfriedt commented Feb 2, 2025 •

edited

Loading

		if (NOT CONFIG_TC_PROVIDES_POSIX_MEMORY_PROTECTION)
		zephyr_library_sources_ifdef(CONFIG_POSIX_MEMORY_PROTECTION mprotect.c)

	if (NOT CONFIG_TC_PROVIDES_XSI_REALTIME)
	if(NOT CONFIG_TC_PROVIDES_XSI_REALTIME)

posix: options: add XSI_REALTIME option group #83303

posix: options: add XSI_REALTIME option group #83303

Conversation

cfriedt commented Dec 21, 2024 • edited Loading

ycsin left a comment

Choose a reason for hiding this comment

cfriedt commented Dec 24, 2024

cfriedt commented Jan 7, 2025 • edited Loading

cfriedt commented Jan 7, 2025

cfriedt Jan 28, 2025 • edited Loading

Choose a reason for hiding this comment

cfriedt Jan 28, 2025

Choose a reason for hiding this comment

cfriedt commented Jan 28, 2025

nordicjm Jan 29, 2025

Choose a reason for hiding this comment

cfriedt Jan 29, 2025

Choose a reason for hiding this comment

cfriedt Jan 29, 2025

Choose a reason for hiding this comment

nordicjm Jan 29, 2025

Choose a reason for hiding this comment

cfriedt Jan 29, 2025

Choose a reason for hiding this comment

ycsin left a comment

Choose a reason for hiding this comment

cfriedt commented Feb 2, 2025 • edited Loading

cfriedt commented Dec 21, 2024 •

edited

Loading

cfriedt commented Jan 7, 2025 •

edited

Loading

cfriedt Jan 28, 2025 •

edited

Loading

cfriedt commented Feb 2, 2025 •

edited

Loading