samples: smp: pi: keep main thread sleeping until ready #84163
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `k_sleep(K_FOREVER)` in the main thread to keep it sleeping while worker threads are running. The last worker thread to finish calculation wakes up the main thread. Signed-off-by: William Tambe <[email protected]>
williamtcdns
force-pushed
the
improve_smp_pi
branch
from
6211d28 to
69d7f4f
Compare
kartben
reviewed
Jan 17, 2025
| @@ -74,7 +76,9 @@ void test_thread(void *arg1, void *arg2, void *arg3) | |||
| buffer += 4; | |||
| } | |||
|
|
|||
| atomic_dec(counter); | |||
| if (atomic_dec(counter) == 1) { | |||
| k_wakeup(main_tid); | |||
There was a problem hiding this comment.
based on k_wakeup usage in-tree, I am not certain this is the recommended approach to wake up current thread (vs. e.g. waiting on a semaphore). Maybe @andyross or @peter-mitsis can chime in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
k_sleep(K_FOREVER)in the main thread to keep it sleeping while worker threads are running. The last worker thread to finish calculation wakes up the main thread.