Upload group conversation image #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domw30
reviewed
Oct 4, 2023
| @@ -457,6 +472,15 @@ export class MatrixClient implements IChatClient { | |||
| return ''; | |||
| } | |||
|
|
|||
| private getRoomAvatar(room: Room): string { | |||
There was a problem hiding this comment.
We could add a helper function for all of these 'get' methods at some point 🙂 will take a look if I happen to work around these
| return (await uploadImage(image)).url; | ||
| } catch (error) { | ||
| // For now, we will just ignore the error and continue to create the room | ||
| // No reason for the image upload to block the room creation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Uploads the group conversation cover image