feat: fetch the users presence asynchronously (isOnline) #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalefukami
reviewed
Oct 16, 2023
src/store/channels-list/saga.ts
Outdated
|
|
||
| if (conversation.isOneOnOne && matrixId) { | ||
| if (isOneOnOne && matrixId) { |
There was a problem hiding this comment.
Don't we still show the green dot on group conversations?
There was a problem hiding this comment.
Yeah actually I don't think this will won't work for group conversations. I'll need to take another look.
There was a problem hiding this comment.
Nice, Updated this!
dalefukami
reviewed
Oct 17, 2023
src/store/channels-list/saga.ts
Outdated
Comment on lines
87
to
88
| if (isOnline) { | ||
| member.isOnline = isOnline; |
There was a problem hiding this comment.
What if isOnline is false? don't we need to set it to false for the user?
There was a problem hiding this comment.
Yeah if the user is offline (i.e., if the presence value is anything other than 'online'), the method will return isOnline: false handled in getUserPresence
const isOnline = presence === 'online';
dalefukami
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
isOnlinestatus by fetching the correct data using matrixsgetPresencemethod.Why are we making this change?
getUser, to set the users online status, this accidentally works as the user will be defaulted tooffline. UsinggetPresenceasynchronously will return the users correct online status. Similar to how we are getting the last seen at data.How do I test this?
Key decisions and Risk Assessment:
Things to consider: