Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group-management): update / handle group management for token gated social channels #2213

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat(group-management): update / handle group management for token gated social channels #2213

merged 2 commits into from
Aug 28, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 28, 2024

What does this do?

  • handles group management when conversation is a social channel, i.e. canEdit, canView, canAddMembers.

Why are we making this change?

  • updates required so group management is enabled for social channels.

How do I test this?

  • run tests as usual.
  • create a social channel and test group management controls.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team August 28, 2024 11:26
@domw30 domw30 merged commit 8bff7b7 into main Aug 28, 2024
5 checks passed
@domw30 domw30 deleted the feat/update-group-management-for-tgc-social-channels branch August 28, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30