Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lightbox): improve ux and apply key event features #2513

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Dec 14, 2024

What does this do?

  • improve ux and apply key event features such as arrow navigation, esc to close etc

Why are we making this change?

  • ux / ui requests
  • adds missing features

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team December 14, 2024 07:38
@domw30 domw30 merged commit 9995f0e into main Dec 14, 2024
5 checks passed
@domw30 domw30 deleted the feat/lightbox-improvements branch December 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant