Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(attachment-preview-modal): add attachment preview modal component #2528

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat(attachment-preview-modal): add attachment preview modal component #2528

merged 1 commit into from
Dec 18, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Dec 18, 2024 •
edited
Loading

What does this do?

  • adds attachment preview modal component

Why are we making this change?

  • to render previews for certain file types

How do I test this?

  • run tests as usual
  • this is not yet wired up to the UI but you can see the screenshot below of the component.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

No Preview Available due to type:

Screenshot 2024-12-18 at 15 17 21

Preview Available:

Screenshot 2024-12-18 at 15 20 15

@domw30 domw30 requested a review from a team December 18, 2024 15:15
@domw30 domw30 merged commit eb9b102 into main Dec 18, 2024
5 checks passed
@domw30 domw30 deleted the feat/add-attachment-preview-modal branch December 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30