Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable QueryClient and configs in React "Getting Started" guide #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

freeatnet
Copy link

This PR fixes incorrect code in @zerodev/waas's "Getting Started" guide. The configs and the QueryClient should be instantiated once,12 rather than on every render.

Footnotes

  1. https://tanstack.com/query/latest/docs/eslint/stable-query-client

  2. https://wagmi.sh/react/getting-started#wrap-app-in-context-provider

@freeatnet
Copy link
Author

As a heads-up, I just noticed that @zerodev/waas suffers from the same issue: https://github.com/zerodevapp/waas/blob/main/src/providers/ZeroDevProvider.tsx#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant