Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: login delay and update next 14.0.4 #2246

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix: login delay and update next 14.0.4 #2246

merged 2 commits into from
Jan 3, 2024

Conversation

darwin808
Copy link
Contributor

@darwin808 darwin808 commented Jan 3, 2024

Description

  • This will fix the login delay when logging in from dev
  • update next js version to 14.0.4

Fixes #2220

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Manual Test
  • Unit Test
  • E2E Test

darwin.apolinario added 2 commits January 3, 2024 12:52
@darwin808 darwin808 self-assigned this Jan 3, 2024
@darwin808 darwin808 changed the title Fix/login delay Fix: login delay and update next 14.0.4 Jan 3, 2024
@darwin808 darwin808 merged commit e154ad5 into stage Jan 3, 2024
10 checks passed
darwin808 added a commit that referenced this pull request Jan 3, 2024
* chore: update next to `14.0.4`

# rebase stage

* fix(auth): login delay

---------

Co-authored-by: darwin.apolinario <[email protected]>
@darwin808 darwin808 deleted the fix/login-delay branch January 3, 2024 12:35

useEffect(() => {
if (!zestyProductionMode) {
setCookie('PRODUCTION', content?.zestyProductionMode);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of setting another cookie here? Looks like this can be derived from the page URL already.

arzljames pushed a commit that referenced this pull request Jan 8, 2024
* chore: update next to `14.0.4`

# rebase stage

* fix(auth): login delay

---------

Co-authored-by: darwin.apolinario <[email protected]>
darwin808 added a commit that referenced this pull request Jan 8, 2024
* update how zesty docs content being rendered

* fix: mindshare rendering issues  (#2233)

* fix(logout): multiple cookies not being deleted (#2227)

Co-authored-by: darwin.apolinario <[email protected]>

* Fix/mindshare rendering issues (#2218)

* fix(pages 1 to 6 mindshare fix rendering): pages 1 to 6 mindshare fix rendering

pages 1 to 6 mindshare fix rendering

* fix(remove unnecessary color): remove unnecessary color

remove unnecessary color

* fix(adjust pre tag background): adjust pre tag background

adjust pre tag background

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>

---------

Co-authored-by: darwin.apolinario <[email protected]>
Co-authored-by: Gian Espinosa <[email protected]>

* Demo page update and bug fixes (#2237)

* fix(logout): multiple cookies not being deleted (#2227)

Co-authored-by: darwin.apolinario <[email protected]>

* Fix/mindshare rendering issues (#2218)

* fix(pages 1 to 6 mindshare fix rendering): pages 1 to 6 mindshare fix rendering

pages 1 to 6 mindshare fix rendering

* fix(remove unnecessary color): remove unnecessary color

remove unnecessary color

* fix(adjust pre tag background): adjust pre tag background

adjust pre tag background

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>

* Feat/dynamic contact form (#2225)

* feat(getdemosection): adjusted demo content based on query params

* chore(clean up): clean up

* chore(usegetdynamicdata): clean up

* feat(demo): update demo page

update demo page to select user journey

* fix(demo): add ternary check to avoid error

* fix(contact page): remove form attributes

* fix(join.js): update copy of the join page (#2236)

* fix(join.js): update copy of the join page

* fix(join.js): update page copy

* fix(join.js): update form copy

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>
Co-authored-by: darwin.apolinario <[email protected]>
Co-authored-by: Gian Espinosa <[email protected]>
Co-authored-by: Jomar Montuya <[email protected]>

* Fix: login delay and update next `14.0.4`  (#2246)

* chore: update next to `14.0.4`

# rebase stage

* fix(auth): login delay

---------

Co-authored-by: darwin.apolinario <[email protected]>

* feat(tags.js): make the tag.js header same with categories to have cta (#2170)

* feat(tags.js): make the tag.js header same with categories to have cta

* chore: remove comments

---------

Co-authored-by: darwin.apolinario <[email protected]>

* Fix/darkmode accounts (#2249)

* fix(logout): multiple cookies not being deleted (#2227)

Co-authored-by: darwin.apolinario <[email protected]>

* Fix/mindshare rendering issues (#2218)

* fix(pages 1 to 6 mindshare fix rendering): pages 1 to 6 mindshare fix rendering

pages 1 to 6 mindshare fix rendering

* fix(remove unnecessary color): remove unnecessary color

remove unnecessary color

* fix(adjust pre tag background): adjust pre tag background

adjust pre tag background

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>

* fix(fix white bg issue and accounts tab): fix white bg issue and accounts tab

fix white bg issue and accounts tab

* fix(fix issue in portal): fix issue in portal

fix issue in portal

* fix(disable portal in dropdown on users menu): disable portal in dropdown on users menu

disable portal in dropdown on users menu

* fix(disable portal on the autocomplete to prevent zindex issue): disable portal

disable portal on the autocomplete to prevent zindex issue

* fix(fixing background issue in darkmode): fixing background issue in darkmode

fixing background issue in darkmode

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>
Co-authored-by: darwin.apolinario <[email protected]>

* fix(contact.js): keep leadsource website as default (#2255)

* fix(contact.js): keep leadsource website as default

* feat(restore): restore

* fix(demo.js): optimize demos page for tablet views (#2259)

* feat: fix ppc explore forms (#2243)

* fix(logout): multiple cookies not being deleted (#2227)

Co-authored-by: darwin.apolinario <[email protected]>

* Fix/mindshare rendering issues (#2218)

* fix(pages 1 to 6 mindshare fix rendering): pages 1 to 6 mindshare fix rendering

pages 1 to 6 mindshare fix rendering

* fix(remove unnecessary color): remove unnecessary color

remove unnecessary color

* fix(adjust pre tag background): adjust pre tag background

adjust pre tag background

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>

* Feat/dynamic contact form (#2225)

* feat(getdemosection): adjusted demo content based on query params

* chore(clean up): clean up

* chore(usegetdynamicdata): clean up

* feat(demo): update demo page

update demo page to select user journey

* fix(demo): add ternary check to avoid error

* fix(contact page): remove form attributes

* fix(join.js): update copy of the join page (#2236)

* fix(join.js): update copy of the join page

* fix(join.js): update page copy

* fix(join.js): update form copy

* feat: fix ppc explore forms

* feat(restore): restore vscode settings

* feat(upadte): updates

* feat(restore vscode): restore vscode settings

* feat(restore vscode settings): fix vscode settings

* fix(fix undefined): fix undefined

---------

Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>
Co-authored-by: darwin.apolinario <[email protected]>
Co-authored-by: Gian Espinosa <[email protected]>

* update(zestydoc.js): removed unused import and variable

* update(zestydoc.js): removed unused import and variable

---------

Co-authored-by: root <[email protected]>
Co-authored-by: Darwin ❤️❤️❤️ <[email protected]>
Co-authored-by: darwin.apolinario <[email protected]>
Co-authored-by: Gian Espinosa <[email protected]>
Co-authored-by: Randy Apuzzo <[email protected]>
Co-authored-by: Jomar Montuya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page redirect to /login has a delay (unauthenticated user)
2 participants