Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hooks and redux for breadcrumbs #1601

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Use hooks and redux for breadcrumbs #1601

merged 5 commits into from
Oct 30, 2023

Conversation

richardolsson
Copy link
Member

Description

This PR migrates the breadcrumbs to use a redux store and hooks.

Screenshots

None

Changes

Notes to reviewer

None

Related issues

Related to #1542
Resolves #524

ziggabyte
ziggabyte approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ziggabyte ziggabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I made small comments that has to do with changes, but they are very small so going to approve because I feel they are not neccessary! Otherwise great!

src/features/breadcrumbs/hooks/useBreadcrumbs.ts Outdated Show resolved Hide resolved
src/features/breadcrumbs/hooks/useBreadcrumbs.ts Show resolved Hide resolved
src/features/breadcrumbs/hooks/useBreadcrumbs.ts Outdated Show resolved Hide resolved
src/features/breadcrumbs/store.ts Show resolved Hide resolved
ziggabyte
ziggabyte approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ziggabyte ziggabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooooooo!!!

@richardolsson richardolsson merged commit 8cec8be into issue-1542/refactor-to-use-hooks Oct 30, 2023
@richardolsson richardolsson deleted the issue-1542/breadcrumbs branch October 30, 2023 20:26
@richardolsson richardolsson mentioned this pull request Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziggabyte ziggabyte ziggabyte approved these changes

@rebecarubio rebecarubio Awaiting requested review from rebecarubio

@kaulfield23 kaulfield23 Awaiting requested review from kaulfield23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardolsson @ziggabyte @kaulfield23