Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate booked participant list before adding #1608

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

annafock
Copy link
Collaborator

@annafock annafock commented Nov 8, 2023

Description

This PR fixes an error where clicking the Book all button will add all signed up participants to the booked participant list, without checking if they are already in it, making the list contain duplicates.

Screenshots

[Add screenshots here]

Changes

[Add a list of features added/changed, bugs fixed etc]

  • Checks if added participant is already in the booked list, only adds the people who are not

Notes to reviewer

My first ever pr in Zetkin. And type script too! yay

Related issues

Resolves #1591

Copy link
Contributor

@kaulfield23 kaulfield23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It looks good and everything works smoothly! Congrats for your first PR! 🥳❤️

@kaulfield23 kaulfield23 merged commit 97038bb into main Nov 9, 2023
4 checks passed
@kaulfield23 kaulfield23 deleted the 1591/fix-book-all-incorrect-numbers branch November 9, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Book all" updates numbers incorrectly
2 participants