Fixes FileUpload comments #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yle property, use theme instead of hardcoded colors,remove type in iconButton
|
There are some comments in the original PR that this PR does not address. I don't know if that's intentional? |
You're right! I've missed some of the comments! 👀 |
richardolsson
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
I think this is good enough to merge, but there are still some minor things left in my comments on #1605 that you can have a look at when you have time.
It might be worth getting this merged now though, so that @ziggabyte and @kaulfield23 can have the most recent code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the changes suggested in the PR #1605
Screenshots
None
Changes
makeStylesanduseStylehooks to add classes instead of inline-styles.styleproperty in components forsxthemeaddFileNotes to reviewer
None
Related issues
Resolves #1598