When dragging to create event in weekly calender, show pop-up label Create event at the bottom of the event
#1613
Conversation
…ender event in weekly calender (when dragging)
|
Great work on this @troldmand! I thought the solution would be much more complicated, so I'm glad you took this on and thought of this very simple fix. I think it looks good. What do you think @ziggabyte (who opened the issue)? |
It seems to work as intended for my small screen also! :D Love a fix as easy as this!! When playing around and trying to provoke the calendar a bit I did, however, run into a behaviour I have not gotten before. I don't think that it is relate to what you changed @troldmand so I'm going to create a separate issue for it: I can drag to create an event beyond the confines of the calendar. |
|
I noticed that as well, yeah. I will happily look into it, if you reference me the issue ticket here when you have created it :) |
Description
This PR solves #1574 by changing the position of the pop-up. When you drag down to create a event, the pop-up should appear close to where you release again, so even without the issue, I find this setting better.
But it also solves the issue, since the position of the pop-up will always be in view. When it was at the top, user would be able to scroll out of view of the position of the pop-up. The pop-up would thus appear outside of the calender.
Screenshots
Before, it would go:
And it is done, to fix this edge case situation:
Notes to reviewer
I have made this assuming the only thing effected by it, would be this "drag down to create" feature in the weekly calender. Maybe consider, if the component is also used elsewhere, maybe make sure it's not ruining something else, somewhere else
Related issues
Resolves #1574