issue-2158/Refactored redux store utility functions #2482
+139
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signment, JoinForms and tags
KraftKatten
commented
Jan 19, 2025
| state.areaList.items = state.areaList.items.filter( | ||
| (item) => item.id != deletedId | ||
| ); | ||
| remoteItemDeleted(state.areaList, deletedId); |
There was a problem hiding this comment.
Same as before, now I don't only remove the item from the list, I also set item.deleted = true. Should be ok, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a start of refactoring Redux store utility functions. It creates utility methods such as create, load, loaded, update, updated and deleted for the remoteData data type. So far, the refactoring applies only to the following features:
Next step is to get this code reviewed and approved, and then I'll continue refactoring for other features as well. Another step is to make tests for this.
Screenshots
Only code changes.
Changes
Notes to reviewer
I'll add some comments in the code
Related issues
The issue won't be completely resolved by this PR.