Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label to overlay close button #280

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions locale/misc/da.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ callLog:
status22: Samtalen blev afbrudt.
tagList:
emptyLabel: Ingen etiketter
close: Tæt
1 change: 1 addition & 0 deletions locale/misc/en.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ callInstructions:
Tap on the number to call, or enter the number manually on your phone.
Tapping the number will open your phone app. Return here to your web
browser to continue using Zetkin and report the call.
close: Close
1 change: 1 addition & 0 deletions locale/misc/nn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ tagList:
} i feltet for personleg info
callInstructions:
instructions: "Klikk på nummeret for å ringe eller tast nummeret manuellt på telefonen. Klikkar du på\_nummeret åpnar telefonappen. Gå så tilbake til nettlesaren for å halde fram i Zetkin og logge samtalen."
close: Lukk
1 change: 1 addition & 0 deletions locale/misc/sv.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ callInstructions:
Tryck på numret ovan för att ringa, eller knappa in det manuellt i din
telefon. När du trycker på numret öppnas din telefonapp. Återvänd hit
till webbläsaren för att fortsätta använda Zetkin.
close: Stänga
3 changes: 3 additions & 0 deletions src/components/overlays/OverlayStack.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import CSSTransitionGroup from 'react-addons-css-transition-group';
import { injectIntl } from 'react-intl';
import { connect } from 'react-redux';

import { resolveOverlay } from '.';
Expand All @@ -11,6 +12,7 @@ const mapStateToProps = state => ({
});

@connect(mapStateToProps)
@injectIntl
export default class OverlayStack extends React.Component {
render() {
let content = null;
Expand All @@ -27,6 +29,7 @@ export default class OverlayStack extends React.Component {
content.push(
<button key="closeButton"
className="OverlayStack-closeButton"
aria-label={this.props.intl.formatMessage({ id: 'misc.close' })}
onClick={ this.onCloseButtonClick.bind(this) }>
</button>
);
Expand Down