Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumb navigation #118

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Add breadcrumb navigation #118

merged 4 commits into from
Jul 25, 2024

Conversation

henrycatalinismith
Copy link
Collaborator

#80

2024-07-14 19 32 28

The Header component becomes always visible in this PR, so there's a bit of incidental paperwork included, which is associated with that change.

@richardolsson richardolsson requested a review from WULCAN July 15, 2024 07:17
@WULCAN WULCAN self-assigned this Jul 22, 2024
WULCAN
WULCAN previously approved these changes Jul 22, 2024
Copy link
Collaborator

@WULCAN WULCAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I have few suggestions and I think we should reserve all but one of them for separate pull requests. The remaining small refactoring is optional of course, but I'd like to hear what you think.

@henrycatalinismith henrycatalinismith merged commit c1acff9 into main Jul 25, 2024
1 check passed
@henrycatalinismith henrycatalinismith deleted the issue-80/breadcrumbs branch July 25, 2024 18:54
@henrycatalinismith henrycatalinismith mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants