Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/137 playwright setup #138
base: main
Are you sure you want to change the base?
Issue/137 playwright setup #138
Changes from all commits
badf15f
2e05c16
98d2d8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the URL does not lead to any documentation.
Screencast.from.2024-10-27.10-10-49.webm
Let's update the URL to something that resolves in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change to correct URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulePathIgnorePatterns
is for making modules non-require()-able in the test environment. Why do we want to do that?https://jestjs.io/docs/configuration#modulepathignorepatterns-arraystring
If it is for ignoring Playwright tests, there is a
testPathIgnorePatterns
that we can use: https://jestjs.io/docs/configuration#testpathignorepatterns-arraystringThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You understood my intent correctly, It is to exclude integration test from running when running jest. :)
Updating this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two new
devDependencies
are whatnpm init playwright@latest
adds.We already have a
devDependency
on@types/node
declared in the root package so we do not need to add a new one here.Lyra does not require Node 22 yet so we should not to update types to types for Node 22.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! :)