Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update styled-components to v6 #515

Open
wants to merge 11 commits into
base: devel
Choose a base branch
from

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Nov 13, 2024

Add $prefix on custom props of styled components.
Remove or replace invalid styles.
Remove types.d.ts declaration file, which was messing types.
Create declaration file for assets.
Update tsconfig to allow js.
Install missing types libraries and augment react-big-calendar which has some wrong typing.
Migrate some simple file to ts.
Add some FIXME comment where additional knowledge/refactor is required to fix the code.

Refs: CO-1609


This comment has been minimized.

@beawar beawar changed the title refactor: uppgrade styled-components to v6 refactor: update styled-components to v6 Nov 21, 2024
@beawar beawar requested review from a team, CataldoMazzilli and rodleyorosa November 22, 2024 08:44
@beawar beawar marked this pull request as ready for review November 22, 2024 08:45

This comment has been minimized.

This comment has been minimized.

Copy link

Failed

  • 42.70% Coverage on New Code (is less than 80.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)
  • 4 New Issues (is greater than 0)

Analysis Details

6 Issues

  • Bug 0 Bugs
  • Vulnerability 2 Vulnerabilities
  • Code Smell 4 Code Smells

Coverage and Duplications

  • Coverage 42.70% Coverage (52.50% Estimated after merge)
  • Duplications 0.21% Duplicated Code (4.10% Estimated after merge)

Project ID: carbonio-calendars-ui

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant