-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update styled-components to v6 #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: CO-1610
There are still some props passed, I need to check them |
Refs: CO-1610
beawar
changed the title
refactor: upgrade styled-components-to-v6
refactor: upgrade styled-components to v6
Nov 21, 2024
beawar
changed the title
refactor: upgrade styled-components to v6
refactor: update styled-components to v6
Nov 21, 2024
3 tasks
gnekoz
approved these changes
Dec 18, 2024
matteobaglini
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add $prefix on custom props of styled components.
Remove or replace invalid styles.
Remove types.d.ts declaration file, which was messing types.
Update tsconfig to allow js.
Update types which were messed up by the declaration file, to reflect the real type.
Add prop types to js components to fix sonar warning. They should be helpful when migrating to typescript.
Add some FIXME comment where the types are too messed up, and additional knowledge/refactor is required to fix them.
Remove unused files.
Remove invalid, unused props.
Split StyledListItem to one simpler styled component and the EnhancedListItem, which takes care of setting the right color for the styled component. Replace its usages.
Refs: CO-1610