Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update styled-components to v6 #266

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

beawar
Copy link
Collaborator

@beawar beawar commented Nov 7, 2024

Add $prefix on custom props of styled components.
Remove or replace invalid styles.
Remove types.d.ts declaration file, which was messing types.
Update tsconfig to allow js.
Update types which were messed up by the declaration file, to reflect the real type.
Add prop types to js components to fix sonar warning. They should be helpful when migrating to typescript.
Add some FIXME comment where the types are too messed up, and additional knowledge/refactor is required to fix them.
Remove unused files.
Remove invalid, unused props.
Split StyledListItem to one simpler styled component and the EnhancedListItem, which takes care of setting the right color for the styled component. Replace its usages.

Refs: CO-1610


@beawar
Copy link
Collaborator Author

beawar commented Nov 7, 2024

There are still some props passed, I need to check them

@beawar beawar closed this Nov 7, 2024
@beawar beawar reopened this Nov 8, 2024
@beawar beawar marked this pull request as ready for review November 21, 2024 17:04
@beawar beawar requested a review from a team as a code owner November 21, 2024 17:04
@beawar beawar changed the title refactor: upgrade styled-components-to-v6 refactor: upgrade styled-components to v6 Nov 21, 2024
@beawar beawar changed the title refactor: upgrade styled-components to v6 refactor: update styled-components to v6 Nov 21, 2024
Copy link

Failed Quality Gate failed

  • 70.70% Coverage on New Code (is less than 80.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)
  • 7 New Issues (is greater than 0)

Project ID: carbonio-contacts-ui

View in SonarQube

@gnekoz gnekoz merged commit 2eda4bc into devel Dec 19, 2024
2 of 3 checks passed
@gnekoz gnekoz deleted the CO-1610-upfrade-styled-components-to-v6 branch December 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants