Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: links public id from 32 to 50 characters #139

Merged
merged 3 commits into from
Jan 2, 2025
Merged

feat: links public id from 32 to 50 characters #139

merged 3 commits into from
Jan 2, 2025

Conversation

galvagnimatteo
Copy link
Contributor

  • Add support for 50 chars public link id
  • Adapted tests to work with 50 chars, keeping the tests for the 32 char public id to make this backwards compatible

Refs: FILES-852

@galvagnimatteo galvagnimatteo requested a review from a team as a code owner November 21, 2024 08:10
@galvagnimatteo galvagnimatteo force-pushed the FILES-852-Links-from-32-to-50-characters branch from 98dd82c to 040aa56 Compare December 18, 2024 10:37
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed Quality Gate failed

  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Project ID: com.zextras.carbonio.files:carbonio-files-ce

View in SonarQube

@galvagnimatteo galvagnimatteo merged commit 0646d26 into develop Jan 2, 2025
2 of 3 checks passed
@galvagnimatteo galvagnimatteo deleted the FILES-852-Links-from-32-to-50-characters branch January 2, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicorispo federicorispo federicorispo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvagnimatteo @federicorispo