[CO-1748] Settings filter #755
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests for it - add ActionFileInto type
- this input supports only one value!
- the test is a bit weak but it's better than testing many things together
- custom select can accept undefined values - find from lodash has been replace with standard find as the return type was incompatible but the behavior should be the same
…tag color behavior defined in filter-action-rows.tsx
…ue an empty input is rendered - note: these tests showcase that some logic should not actually be in this component
- add more tests for tag color
- setDestination is not available anymore anyway
|
0 New Issues
6 Fixed Issues
0 Accepted Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.