Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: require ^1.12.20 #1

Closed
wants to merge 1 commit into from
Closed

composer: require ^1.12.20 #1

wants to merge 1 commit into from

Conversation

glensc
Copy link

@glensc glensc commented May 6, 2019

require version that uses "replace" of old "zf1" namespace.

should fix problem reported here:

this is at least first level. but as i see, all interdependencies should be updated.

cc @falkenhawk

@glensc
Copy link
Author

glensc commented May 6, 2019

alternatively, you could just drop older tags than 1.12.20, because these do not provide "replace" keyword.

@glensc
Copy link
Author

glensc commented May 6, 2019

this kind of change is definitely needed, even own packages from zf1s organization install older packages and from zf1 namespace:

$ composer install --no-interaction --prefer-dist
Updating dependencies (including require-dev)
Package operations: 10 installs, 0 updates, 0 removals
  - Installing zf1s/zend-exception (1.12.20): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-xml (1.12.20): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-registry (1.12.20): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-cache (1.12.21): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-locale (1.12.20): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-loader (1.12.21): Downloading (connecting...)Downloading (100%)
  - Installing zf1/zend-validate (1.12.11): Downloading (connecting...)Downloading (100%)
  - Installing zf1/zend-uri (1.12.11): Downloading (100%)
  - Installing zf1/zend-config (1.12.11): Downloading (connecting...)Downloading (100%)
  - Installing zf1s/zend-controller (1.12.11): Downloading (connecting...)Downloading (100%)
zf1s/zend-cache suggests installing zf1s/zend-log (Used in special situations or with special adapters)
zf1/zend-validate suggests installing zf1/zend-date (Used in special situations or with special adapters)
zf1/zend-validate suggests installing zf1/zend-filter (Used in special situations or with special adapters)
zf1/zend-uri suggests installing zf1/zend-date (Used in special situations or with special adapters)
zf1/zend-uri suggests installing zf1/zend-filter (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1/zend-dojo (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1/zend-filter (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1/zend-json (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1/zend-layout (Used in special situations or with special adapters)

@falkenhawk
Copy link
Member

I tried to reproduce it but composer does not resolve to any zf1 package for me locally, do you have an idea why that happens on travis?

λ composer install
    1/12:       http://repo.packagist.org/p/provider-archived$78a619eac330e4c5225df9153833d7acdf6bb978ea13bb33d6368de7b7d1e95c.json
    2/12:       http://repo.packagist.org/p/provider-latest$9d72612ed5b13fcd86d1e9b66d7fdc1c37d561adeaa2b773c0787bca24f59e83.json
    3/12:       http://repo.packagist.org/p/provider-2013$d37e4903130332a42fe3f9fc67c3c0706bd1c4701131de1cd01a5b9ae2ba698d.json
    4/12:       http://repo.packagist.org/p/provider-2014$22bfcfb8a4658aba97e0b78bf747bde451a9ce3819fa35e8a18d34c066da1399.json
    5/12:       http://repo.packagist.org/p/provider-2019-04$c987e6f8d1c4a9a90b77784e20c97c1d97945689b7a44efb8be6ae0cfeb0a52c.json
    6/12:       http://repo.packagist.org/p/provider-2018-07$19a186f4ef933a56f3466e6f77b2fba88d62787a54bf49f617255ebc4cae2edb.json
    7/12:       http://repo.packagist.org/p/provider-2018-10$dce8df6c35c90f5bbe9d773c8d0f4cbe7016a2a4a2a0be4069063dc537dce930.json
    8/12:       http://repo.packagist.org/p/provider-2015$e0425a4faf29db15a5aa3d39d48864ba102cf2cfb9c922fa157182534458c68c.json
    9/12:       http://repo.packagist.org/p/provider-2019-01$40e00b5b09ba71c76bae08f733ed5aa59aa4659bef711699c831bb77d4ed9933.json
    10/12:      http://repo.packagist.org/p/provider-2016$fecfadf2b0689b80718e497b3443f84b2c775a5c714909ea6ae24630cd4a7064.json
    11/12:      http://repo.packagist.org/p/provider-2018$8e4a88ea40651d662fe933542222564f34b60c1001b3661abedca54942ec8878.json
    12/12:      http://repo.packagist.org/p/provider-2017$aeefbefa075d2b2dcb240bf8912a2e7617c17142d4c3abce940daa329d6c6d4a.json
    Finished: success: 12, skipped: 0, failure: 0, total: 12
Loading composer repositories with package information
Updating dependencies (including require-dev)
    Finished: success: 0, skipped: 0, failure: 5, total: 5
Package operations: 10 installs, 0 updates, 0 removals
  - Installing zf1s/zend-exception (1.12.20): Loading from cache
  - Installing zf1s/zend-xml (1.12.20): Loading from cache
  - Installing zf1s/zend-registry (1.12.20): Loading from cache
  - Installing zf1s/zend-cache (1.12.21): Downloading (100%)
  - Installing zf1s/zend-locale (1.12.20): Loading from cache
  - Installing zf1s/zend-loader (1.12.21): Downloading (100%)
  - Installing zf1s/zend-controller (1.12.21): Downloading (100%)
  - Installing zf1s/zend-validate (1.12.21): Downloading (100%)
  - Installing zf1s/zend-uri (1.12.20): Loading from cache
  - Installing zf1s/zend-config (1.12.21): Downloading (100%)
zf1s/zend-cache suggests installing zf1s/zend-log (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-dojo (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-json (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-layout (Used in special situations or with special adapters)
zf1s/zend-validate suggests installing zf1s/zend-date (Used in special situations or with special adapters)
zf1s/zend-validate suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
zf1s/zend-uri suggests installing zf1s/zend-date (Used in special situations or with special adapters)
zf1s/zend-uri suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
Writing lock file
Generating autoload files

Tried with --prefer-dist flag:

λ composer install --prefer-dist
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 10 installs, 0 updates, 0 removals
  - Installing zf1s/zend-exception (1.12.20): Loading from cache
  - Installing zf1s/zend-cache (1.12.21): Loading from cache
  - Installing zf1s/zend-xml (1.12.20): Loading from cache
  - Installing zf1s/zend-registry (1.12.20): Loading from cache
  - Installing zf1s/zend-locale (1.12.20): Loading from cache
  - Installing zf1s/zend-loader (1.12.21): Loading from cache
  - Installing zf1s/zend-validate (1.12.21): Loading from cache
  - Installing zf1s/zend-uri (1.12.20): Loading from cache
  - Installing zf1s/zend-config (1.12.21): Loading from cache
  - Installing zf1s/zend-controller (1.12.21): Loading from cache
zf1s/zend-cache suggests installing zf1s/zend-log (Used in special situations or with special adapters)
zf1s/zend-validate suggests installing zf1s/zend-date (Used in special situations or with special adapters)
zf1s/zend-validate suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
zf1s/zend-uri suggests installing zf1s/zend-date (Used in special situations or with special adapters)
zf1s/zend-uri suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-dojo (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-filter (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-json (Used in special situations or with special adapters)
zf1s/zend-controller suggests installing zf1s/zend-layout (Used in special situations or with special adapters)
Generating autoload files

I also removed composer's cache and tried again, but it again installed only zf1s packages

@glensc
Copy link
Author

glensc commented May 6, 2019

I created reproducer in zf1s/zend-application#2 (comment):

how it behaves there?

@falkenhawk
Copy link
Member

I tested it there: zf1s/zend-application#2 (comment) but here we have an output from travis installing just zend-view package - and it should not install any zf1 packages as dependencies...

@glensc
Copy link
Author

glensc commented May 6, 2019

yes, more changes needed to use ^1.12.20. i.e all inner dependencies must be changed... or just delete older tags, at least from packagist.org. but that is asking for trouble as they may appear back so, should be deleted on github as well.

@glensc
Copy link
Author

glensc commented May 22, 2019

@falkenhawk can you please decide something:

  1. drop older tags and consider them unsupported
  2. update all internal deps ^1.12.20

I understand you're busy with monorepo, but just answer would be nice to have.

falkenhawk added a commit that referenced this pull request Dec 12, 2022
- substr(): Passing null to parameter #1 ($string) of type string is deprecated
- strtolower(): Passing null to parameter #1 ($string) of type string is deprecated
- strlen(): Passing null to parameter #1 ($string) of type string is deprecated
- trim(): Passing null to parameter #1 ($string) of type string is deprecated
- str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated
- strstr(): Passing null to parameter #1 ($haystack) of type string is deprecated
- http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated
- current(): Calling current() on an object is deprecated
- preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
- preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated
- always construct Zend_Exception with string message, avoid null
- Implicit conversion from float-string "x.xyz" to int loses precision
- PDOStatement::fetch(): Passing null to parameter #2 ($cursorOrientation) of type int is deprecated
- ctype_space(): Argument of type null will be interpreted as string in the future
- file_get_contents(): Passing null to parameter #2 ($use_include_path) of type bool is deprecated
- imagefilledpolygon(): Using the $num_points parameter is deprecated
- Implicit conversion from float to int loses precision
- PDOStatement::bindParam(): Passing null to parameter #4 ($maxLength) of type int is deprecated
- preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
- ctype_print(): Argument of type int will be interpreted as string in the future
- trim(): Passing null to parameter #1 ($string) of type string is deprecated
etc.
@falkenhawk falkenhawk closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants