Using instance Zend_Form_Element instead of directly adding an element to the form. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsferred Zend_From_Element
Using objects
Merge branch 'hotfix/file_decorator'
Add file type decorator
Add SubForm
Solve error with strict standards: Only variables should be passed by reference
* Prevent PHP (7) Error Solve error with strict standards: Only variables should be passed by reference * Remove dimensions if any
Twitter_Bootstrap3_View_Helper_FormReset must be setup in the same way Zend_View_Helper_FormReset is setup, otherwise this will cause exception.
If adding elements to a form, class is lost. This is especially true for selects and such elements, which do not have a special view helper. Added manual assignment of class if class is given.
* Prevent PHP (7) Error Solve error with strict standards: Only variables should be passed by reference * Remove dimensions if any * Comply with Zend_View_Helper_FormReset Twitter_Bootstrap3_View_Helper_FormReset must be setup in the same way Zend_View_Helper_FormReset is setup, otherwise this will cause exception. * Add support for "class" attrib If adding elements to a form, class is lost. This is especially true for selects and such elements, which do not have a special view helper. Added manual assignment of class if class is given.
Get current state from upper fork.
They use HTML inside quite often - disable escaping globally.
Add inline form with label. Use it like: $form = new Twitter_Bootstrap3_Form_Inlinelabel;
Add possibility to add a class to the div around the input to the form-group class by attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects, we use object instances Zend_Form_Elements instead of directly adding them to the form. Thanks to keep the transparency of the code and it is easier to manage. Since decorators in this case were not supported, I overwrite standard method addElement to handle this in a way as direct adding form elements.