Added new modules for password rules #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: * Added a new target 'end2end_mocked' to the Makefile that runs the end2end tests against mock environments defined with a new HMC inventory file (mocked_inventory.yaml) and a new HMC vault file (mocked_vault.yaml). * Added the new make target to the GitHub Actions test workflow. * Added new mock files that define a mocked HMC for thee tests: * mocked_z14_classic.yaml - for an HMC managing a z14 in classic mode * mocked_z14_dpm.yaml - for an HMC managing a z14 in DPM mode * Enabled testing with mock support in the existing end2end testcases: * test_zhmc_partition.py * test_zhmc_user.py * Increased the minimum version of zhmcclient to 1.3.1, in order to pick up the fix for the filepath AttributeError. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/add-password-rule-modules
branch
from
2b73b1e to
2be9adf
Compare
andy-maier
force-pushed
the
andy/add-password-rule-modules
branch
2 times, most recently
from
8d21a17 to
a6f75b8
Compare
Details: * Added a new module 'zhmc_password_rule' that supports creating/updating, deleting, and gathering facts of a password rule on the HMC. (issue #363) * Added a new module 'zhmc_password_rule_list' that supports listing the names of password rules on the HMC. (issue #363) * Improved the mocked HMCs defined in mocked_z14_classic.yaml and mocked_z14_dpm.yaml to define password rules with all properties. * Changed the password rule 'Basic' that is used in the end2end tests to 'Standard'. * Increased zhmcclient to 1.4.0 (currently still pulled drom master branch) in orde to pick up improvements in mock support for password rules. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/add-password-rule-modules
branch
from
a6f75b8 to
43a9a75
Compare
vkathir82
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is on top of PR #535. Review only the delta.
Merge only after PR #535 has been merged.