1.7: Added 'make ansible_lint' and fixed some of the ansible-lint issues reported #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
1.7/andy/ansible-lint
branch
from
d019ac3 to
65b474b
Compare
…eported Details: * Added ansible-lint to the development dependencies. Needed to increase some package dependencies for development and also for installation. * Added a new make target 'ansible_lint' for running ansible-lint, in order to get a preview of the AutomationHub import warnings. * Added 'make ansible_lint' as a new step to the Github Actions test workflow. * Resolved the issues reported by 'make ansible_lint' where possible. The remaining issues are those that are also reported by the Ansible AutomationHub import. * Removed some directories from being added into the distribution archive for the collection: - docs - tests/end2end - tests/function - tests/unit Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
1.7/andy/ansible-lint
branch
from
65b474b to
49a5aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back PR #839 into 1.7.4.
No review needed.