Automatic detection of HMC resources that no longer exist #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
changed the title
andy-maier
force-pushed
the
andy/handle-ceased-existence
branch
4 times, most recently
from
158605d to
de83c69
Compare
andy-maier
force-pushed
the
andy/handle-ceased-existence
branch
2 times, most recently
from
d3ccc80 to
96425e4
Compare
Details: * HMC resources that no longer exist are automatically removed from the exported metrics. (Issue #203) Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/handle-ceased-existence
branch
from
96425e4 to
bc7c16c
Compare
andy-maier
changed the title
vkathir82
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the resource removal part of issue #203 . The addition of new resources will be in a separate PR.
For details, see the commit message.
Test: Since we don't have end2end testcases yet, and since this is difficult to test in unit tests, I have not added test cases. However, the function has been tested by creating an extra test partition, starting the exporter, removing the test partition, and verifying that it disappears from the Prometheus data.