Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5: Fixed warning about ignoring label 'adapter/port' #458

Merged

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Feb 19, 2024

Rolls back PR #457 into 1.5.1.
No separate review needed.

Details:

* Fixed warning about ignoring label 'adapter/port' on metric group
  'partition-attached-network-interface' due to error in rendering the Jinja2
  expression for a label value. (issue #450)

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier added this to the 1.5.1 milestone Feb 19, 2024
@andy-maier andy-maier self-assigned this Feb 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 35.393% (-0.9%) from 36.255%
when pulling 836e463 on 1.5/andy/fix-label-ignore-warning-adapter-port
into 8d53f6b on stable_1.5.

@andy-maier andy-maier merged commit 9e3e12a into stable_1.5 Feb 23, 2024
17 checks passed
@andy-maier andy-maier deleted the 1.5/andy/fix-label-ignore-warning-adapter-port branch February 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignoring labels adapter/port on metric group partition-attached-network-interface
2 participants