Fixed the build of the docker image #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-docker
branch
from
a22f8be to
3df026d
Compare
andy-maier
force-pushed
the
andy/fix-docker
branch
2 times, most recently
from
7f21f2b to
75f9a0f
Compare
andy-maier
force-pushed
the
andy/fix-docker
branch
from
75f9a0f to
349d0ae
Compare
andy-maier
force-pushed
the
andy/fix-docker
branch
2 times, most recently
from
fba79ce to
e971877
Compare
…mage Details: * The Dockerfile used the python:3.12-slim image for the builder environment and switched that to the python:3.12-alpine image for the final container environment. The installation of the 'rpds' Python package builds a shared library. That library was built against the builder OS and then attempted to be run in the (different) final OS. The two OS images were different enough for that to fail. Fixed that by using the same OS image python:3.12-slim for both enviroments. This increased the image size from 86 MB to 186 MB. * Added showing the rpds package files to the docker builder phase. * Added test to 'docker make' for running the docker image to show the exporter version. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-docker
branch
from
e971877 to
d45d52c
Compare
|
After Anilak's approval, I added running the docker image for testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.