Skip to content

Commit

Permalink
Fixed coveralls not found on MacOS with py39-311
Browse files Browse the repository at this point in the history
Signed-off-by: Andreas Maier <[email protected]>
  • Loading branch information
andy-maier committed Sep 16, 2024
1 parent 0e588ab commit 70c11bb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ jobs:
\"python-version\": \"3.8\", \
\"package_level\": \"latest\" \
}, \
{ \
\"os\": \"macos-latest\", \
\"python-version\": \"3.11\", \
\"package_level\": \"latest\" \
}, \
{ \
\"os\": \"macos-latest\", \
\"python-version\": \"3.12\", \
Expand Down Expand Up @@ -198,7 +203,6 @@ jobs:
run: |
make test
- name: Send coverage result to coveralls.io
shell: bash -l {0}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_PARALLEL: true
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ else
RMDIR_R_FUNC = find . -type d -name '$(1)' | xargs -n 1 rm -rf
CP_FUNC = cp -r $(1) $(2)
ENV = env | sort
WHICH = which
WHICH = which -a
endif

# Default path names of HMC inventory and vault files used for end2end tests.
Expand Down
3 changes: 3 additions & 0 deletions changes/1665.fix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Test: Fixed the issue that coveralls was not found in the test workflow on MacOS
with Python 3.9-3.11, by running it without login shell. Added Python 3.11 on
MacOS to the normal tests.

0 comments on commit 70c11bb

Please sign in to comment.