Fix #411 Javascript Error #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekwah41
force-pushed
the
sekwah/js-error-fix
branch
2 times, most recently
from
9d514e2 to
d3813d9
Compare
|
For some reason, it also triggers possibly even if you don't interact, though i may have a old testing install, I believe there is an input field? Though I am not sure if that causes it to not callback if its not interacted with. Ill need to check that. It seems the custom appId toast notifications are in a bad state for windows. |
|
Im not sure what was going on the other day but it was returning undefined at one point, but after a re-install and update it seems to be fine. |
sekwah41
force-pushed
the
sekwah/js-error-fix
branch
from
d3813d9 to
ec85afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the underlying electron store is called and errors are thrown.
The logic should be fine though we need to keep an eye in case this causes other issues.