Skip to content

fix emscripten compile #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

fix emscripten compile #38

merged 1 commit into from
Apr 19, 2025

Conversation

vkensou
Copy link
Contributor

@vkensou vkensou commented Apr 5, 2025

compiler report error: error: '__EMSCRIPTEN__' macro redefined.

@vkensou
Copy link
Contributor Author

vkensou commented Apr 5, 2025

define IMGUI_IMPL_WEBGPU_BACKEND_WGPU in imgui_impl_wgpu.h and imgui_impl_wgpu.cpp break compile on emscripten

@hazeycode hazeycode requested a review from ckrowland April 15, 2025 22:55
ckrowland
ckrowland reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@ckrowland ckrowland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are in PR #22. Once we merge that it should work.

@ckrowland
Copy link
Contributor

But this would work by itself if you want to merge this before #22

@hazeycode hazeycode merged commit 1ec8c63 into zig-gamedev:main Apr 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckrowland ckrowland ckrowland left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkensou @ckrowland @hazeycode