remove using namepace #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be better to move the code from zmath.zig directly to main.zig. It will be without |
hazeycode
requested changes
Mar 20, 2025
There was a problem hiding this comment.
As @OndraVoves pointed out we can just move the contents of zmath.zig to the root module file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of usingnamespace #7 but the import is done a little bit differently as seen in the updated readme. This seems like the simplest way to fix this, in terms of changes made.
This is done because usingnamesapce is going to be removed soon and also without it we can use incremental compilation.