Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for in memory exporter #3

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add test for in memory exporter #3

merged 2 commits into from
Oct 15, 2024

Conversation

inge4pres
Copy link
Collaborator

No description provided.

@inge4pres
Copy link
Collaborator Author

Current code tests failing with

Segmentation fault at address 0x7f12a7f20000
error: while executing test 'metrics.exporter.test.in memory exporter stores data', the following command terminated with signal 11 (expected exited with code 0):

@inge4pres inge4pres marked this pull request as ready for review October 15, 2024 09:30
@inge4pres inge4pres changed the title WIP: add test for in memory exporter Add test for in memory exporter Oct 15, 2024
@inge4pres
Copy link
Collaborator Author

Last commit also introduces a refactor based on the concept of interface embedding detailed in https://zig.news/david_vanderson/interfaces-in-zig-o1c

Thanks Loris Cro for the pointer 🙏🏼

@inge4pres inge4pres merged commit 9b835e6 into main Oct 15, 2024
2 checks passed
@inge4pres inge4pres deleted the refine-inmem-exporter branch October 15, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inge4pres