Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage2: fix @sizeOf() for vector types. #12028

Closed
wants to merge 1 commit into from
Closed

Conversation

xxxbxxx
Copy link
Contributor

@xxxbxxx xxxbxxx commented Jul 6, 2022

stage1 does

        entry->abi_size = LLVMABISizeOfType(g->target_data_ref, example_vector_llvm_type);
        entry->abi_align = LLVMABIAlignmentOfType(g->target_data_ref, example_vector_llvm_type);

but looks like it's actually pretty direct, same as alignment. (next power-of-2)
maybe some architectures are different?

follow-up of 095e24e

closes #12026

@andrewrk
Copy link
Member

andrewrk commented Jul 7, 2022

Thanks for the patch!

Note that this changed in LLVM 14. Here is the corresponding alignment patch: b698168

@xxxbxxx xxxbxxx force-pushed the master branch 3 times, most recently from 903a1a7 to a39eab8 Compare July 7, 2022 18:38
@xxxbxxx
Copy link
Contributor Author

xxxbxxx commented Jul 7, 2022

not smart enough to get the tests to pass both on llvm13 and llvm14 -> rebasing on llvm14 branch..

@xxxbxxx xxxbxxx closed this Jul 7, 2022
@xxxbxxx xxxbxxx reopened this Jul 13, 2022
@xxxbxxx xxxbxxx force-pushed the master branch 4 times, most recently from 3056641 to b936762 Compare July 14, 2022 19:11
@xxxbxxx
Copy link
Contributor Author

xxxbxxx commented Jul 24, 2022

done better by a37cd0b from #12145.

@xxxbxxx xxxbxxx closed this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stage2 miscompilation involving vectors
2 participants