std.math: allow comptime_floats in isInf and isNan #23357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootbeer
force-pushed
the
22107-comptime-isinf
branch
from
8147a26 to
2bcfbc9
Compare
rootbeer
force-pushed
the
22107-comptime-isinf
branch
from
2bcfbc9 to
aa67b9f
Compare
Currently constants passed to these functions trigger an obtuse: `error: access of union field 'float' while field 'comptime_float' is active` where the work-around is to cast the constant into a runtime float. From ziglang#21205, I'm leveraging the fact that `comptime_float` won't (eventually) support NaN or infinity, so the `isNan` and `isInf` methods can unilaterally return false for `comptime_float` parameters. Add tests for comptime floats passed to isNan, isInf*. See ziglang#23258 for the motivation. Fixes ziglang#22107
rootbeer
force-pushed
the
22107-comptime-isinf
branch
from
aa67b9f to
f3f4848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently constants passed to
std.math.isInfandstd.math.isNantrigger an obtuse (to me):error: access of union field 'float' while field 'comptime_float' is active. The work-around is to cast the constant into a runtime float.From #21205, I'm leveraging the idea that
comptime_floatwon't (eventually) support NaN or infinity, so theisNanandisInfmethods can unilaterally return false given anycomptime_floatparameters.Perhaps short-circuiting at this layer is the wrong approach (or I'm mis-interpreting that proposal), and a more appropriate fix would be at a lower layer?
Also add tests for comptime floats passed to
isNan,isInf*.See #23258 for the motivation.
Fixes #22107