std: Make PriorityQueue and PriorityDequeue unmanaged containers

[allocgator]

Edit:

Revived #21433

Solves: #21432

---

Can I merge

/// Pop the highest priority element from the queue. Returns `null` if empty.
pub fn removeOrNull(self: *Self) ?T {
    return if (self.items.len > 0) self.remove() else null;
}

and

/// Remove and return the highest priority element from the queue
pub fn remove(self: *Self) T {
    return self.removeIndex(0);
}

into a single method

/// Pop the highest priority element from the queue. Returns `null` if empty.
pub fn remove(self: *Self) ?T {
    return if (self.items.len > 0) self.removeIndex(0) else null;
}

?

This would make the new remove method similar to the peek method.

[bndbsh]

Note that the comment still mentions pop which doesn't exist. Would be nice to update that (or maybe rename remove)

[allocgator]

Note that the comment still mentions pop which doesn't exist. Would be nice to update that (or maybe rename remove)

pop makes sense as its a queue data structure and its functionality is currently provided by removeOrNull.

Furthermore, if there's a pop method, it may also involve renaming add related methods to push.

Not sure if that comment is from one of the reviewers.

Looping in @alexrp for feedback on:

1. Renaming

   • insert methods to push methods
   • removeIndex to popIndex

2. Combining removeOrNull and remove into pop, where the new pop method looks like:

pub fn pop(self: *Self) ?T {
    return if (self.items.len > 0) self.popIndex(0) else null;
}