std.Build.Step.Run: Add support for LazyPath environment variables #23491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #19482
This is a breaking change as there is no longer a directly accessible
process.EnvMap
.This makes the
addPathDir
API little awkward. Currently it just silently returns early if the PATH environment variable is not the string variant. PerhapsEnvVar
should have a list variant where each element is either a string or aLazyPath
. That would add a lot of complexity though.Whether environment variables should have all the same variants as command line arguments (
addArtifactArg
,addPrefixedArtifactArg
,addOutputDirectoryArg
etc.) should also be discussed.