Skip to content

std.Build.Step.Run: Add support for LazyPath environment variables #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toivosnare
Copy link

@toivosnare toivosnare commented Apr 7, 2025

Implements #19482

This is a breaking change as there is no longer a directly accessible process.EnvMap.

This makes the addPathDir API little awkward. Currently it just silently returns early if the PATH environment variable is not the string variant. Perhaps EnvVar should have a list variant where each element is either a string or a LazyPath. That would add a lot of complexity though.

Whether environment variables should have all the same variants as command line arguments (addArtifactArg, addPrefixedArtifactArg, addOutputDirectoryArg etc.) should also be discussed.

@toivosnare toivosnare force-pushed the run-step-lazypath-envvars branch 2 times, most recently from 73255e9 to e7ba461 Compare April 7, 2025 10:32
@toivosnare toivosnare force-pushed the run-step-lazypath-envvars branch from e7ba461 to c9ed1e7 Compare April 8, 2025 06:09
@toivosnare toivosnare marked this pull request as draft April 8, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant